Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Email Content #280

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Conversation

ExtremeFiretop
Copy link
Owner

@ExtremeFiretop ExtremeFiretop commented Aug 4, 2024

Clarify Email Content as requested by:

https://www.snbforums.com/threads/merlinau-v1-2-6-the-ultimate-firmware-auto-updater-now-available-in-amtm.88577/post-920655

Also, noticed that when the primary emails about updates for the nodes it looked a bit weird:

image

Basically I'd get an update email notification, the subject made it sound like the primary had an update (GT-BE98Pro), but then reading you could tell it was a node update. (GT-AXE11000)

So I addressed both my nitpick and the user request at the same time.

Clarify Email Content
@ExtremeFiretop ExtremeFiretop marked this pull request as ready for review August 4, 2024 10:52
@Martinski4GitHub
Copy link
Collaborator

Also, noticed that when the primary emails about updates for the nodes it looked a bit weird:
...
Basically I'd get an update email notification, the subject made it sound like the primary had an update (GT-BE98Pro), but then reading you could tell it was a node update. (GT-AXE11000)

Nice catch!!

Copy link
Collaborator

@Martinski4GitHub Martinski4GitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@Martinski4GitHub Martinski4GitHub merged commit 1a38042 into dev Aug 5, 2024
1 check passed
Repository owner deleted a comment from Martinski4GitHub Aug 5, 2024
@Martinski4GitHub
Copy link
Collaborator

@ExtremeFiretop,
Did you just delete my previous comment by accident??

@ExtremeFiretop
Copy link
Owner Author

@ExtremeFiretop, Did you just delete my previous comment by accident??

Yes I was trying to delete my comment from the other PR.

@Martinski4GitHub
Copy link
Collaborator

@ExtremeFiretop, Did you just delete my previous comment by accident??

Yes I was trying to delete my comment from the other PR.

That's what happens when you haven't had your full cup of coffee to really wake up!! LOL!!

@ExtremeFiretop
Copy link
Owner Author

@ExtremeFiretop, Did you just delete my previous comment by accident??

Yes I was trying to delete my comment from the other PR.

That's what happens when you haven't had your full cup of coffee to really wake up!! LOL!!

My eyes are blurry and I'm on my phone, I lost track of what PR I was on and just scrolled to the bottom on my phone and hit the delete button. Lol.

I realized my reply on the other PR was a bit dry, so I just wanted to delete it and re-write the fact that I had seen that in testing and was already fixed locally.

The only thing you did differently was you choose a different location to do the update for the function. Otherwise they were pretty much identical.

@ExtremeFiretop ExtremeFiretop deleted the ExtremeFiretop-patch-EmailContent branch August 5, 2024 09:56
@ExtremeFiretop
Copy link
Owner Author

Synced with Gnuton in commit: c63a577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants