Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes & code improvements #281

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

Martinski4GitHub
Copy link
Collaborator

Found a couple of issues with PR #280.

  • Fixed issue with variable "FW_UpdateDate" not being updated at run time when changes were made to the scheduled CRON job or the number of postponed days.

  • Fixed issue with variable "FW_UpdateDate" not being updated before sending the NEW_FW_UPDATE_STATUS email notification.

  • Various code improvements & fine-tuning.

Fixed issue with variable "FW_UpdateDate" not being updated at run time when changes were made to schedule CRON job or postponement days.
Fixed issue with variable "FW_UpdateDate" not being updated before sending the NEW_FW_UPDATE_STATUS email notification.
Various code improvements & fine-tuning.
@ExtremeFiretop ExtremeFiretop merged commit 7942ccf into ExtremeFiretop:dev Aug 5, 2024
1 check passed
@ExtremeFiretop
Copy link
Owner

ExtremeFiretop commented Aug 5, 2024

Yeah I was actually mostly done all this myself from last night.

I was just waiting until I got out of bed to submit it but I guess I don't need to get out of bed anymore :)

@Martinski4GitHub
Copy link
Collaborator Author

Yeah I was actually mostly done all this myself from last night.

I was just waiting until I got out of bed to submit it but I guess I don't need to get out of bed anymore :)

Well, you're welcome!! Now go back to sleep!! LOL :>).

@ExtremeFiretop
Copy link
Owner

I have the day off today so I will actually 😂
Chat later buddy, enjoy the day

@Martinski4GitHub
Copy link
Collaborator Author

I have the day off today so I will actually 😂 Chat later buddy, enjoy the day

Nice!! Then enjoy your sleep and the rest of the day, bud. We'll talk later.
Signing off.

@ExtremeFiretop
Copy link
Owner

I have the day off today so I will actually 😂 Chat later buddy, enjoy the day

Nice!! Then enjoy your sleep and the rest of the day, bud. We'll talk later. Signing off.

We'll chat this afternoon or this evening whenever your available. I have more things to discuss later. You just happened to beat me to the punch on this one ;)

@ExtremeFiretop
Copy link
Owner

Synced with Gnuton in commit: 717c904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants