Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update T3 Mobile AA File Directory Names #3341

Merged
merged 11 commits into from
Aug 17, 2021
Merged

Update T3 Mobile AA File Directory Names #3341

merged 11 commits into from
Aug 17, 2021

Conversation

MrRowey
Copy link
Member

@MrRowey MrRowey commented Aug 11, 2021

The Unit Id on the Unit database should take you to the Blueprint for the unit. This is the quickest way to do it but with the T3 Mobile AA the Unit Folders are all in LowerCase so the link the the Unit DB is pulling seems to be Case Sensitive as it throwing a 404 page as it is after the unit folder in Capitals like all the other units

So the Unit Folders need to be as following
DRLK001
DELK002
DALK002
DSLK004

units/DSLK004/DSLK004_script.lua Outdated Show resolved Hide resolved
@MrRowey
Copy link
Member Author

MrRowey commented Aug 11, 2021

Ive Not Changed any files inside the folder i literlay downloed FA-Develop Renamed the folders in CAPS and deleted the folders in lower case thats all i changed. Im not aware of a quicker and simpler way of renaming a Folder Directory on Github.

@Garanas
Copy link
Member

Garanas commented Aug 11, 2021

I'll revert the changes - after that I see no reason why we should not accept this.

#2527 Part of this issuse with Comment about the other units
@Garanas
Copy link
Member

Garanas commented Aug 12, 2021

@Tagada14 is the last change of Rowey all good? It means that the reload bar is visible, similar to summits.

@Garanas
Copy link
Member

Garanas commented Aug 12, 2021

And @MrRowey could you make a separate PR for the reload bars?

@MrRowey
Copy link
Member Author

MrRowey commented Aug 12, 2021

@Garanas Yeh sorry forgot to make a seperate branch on my fork so i pull the first change here xD

@Garanas
Copy link
Member

Garanas commented Aug 13, 2021

Reverted the changes, merging this PR on Monday morning unless there are objections. Great work Rowey!

@Garanas Garanas merged commit 65337ac into FAForever:deploy/fafdevelop Aug 17, 2021
@shalkya shalkya added this to the 3720 milestone Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants