Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename folder to match blueprint id #3367

Merged

Conversation

Garanas
Copy link
Member

@Garanas Garanas commented Aug 20, 2021

This is an error introduced by me when trying to fix the file history of files changed by #3341 . I made a typo, this PR fixes that typo. Sadly, the original fix did not restore the file history as you can see here: https://github.com/FAForever/fa/commits/deploy/fafdevelop/units/DLSK004

@Sheikah45 maybe you know why the file history was lost after renaming the folder?

@speed2CZ
Copy link
Member

isaacs/github#900

@Sheikah45
Copy link
Member

Yes sadly github does not handle folder renames particularly well at the moment

@Garanas
Copy link
Member Author

Garanas commented Aug 20, 2021

Then I'm just merging this and taking the loss on Monday morning, unless there are objections to it.

@Garanas Garanas merged commit d91608e into FAForever:deploy/fafdevelop Aug 24, 2021
@shalkya shalkya added this to the 3720 milestone Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants