[pull] main from microsoft:main

.eslintrc.js

@@ -6,9 +6,14 @@ module.exports = {
  sourceType: "module",
  },
  extends: [
+ "plugin:react/recommended",
  "plugin:react-hooks/recommended"
  ],
 
+ settings: {
+ react: { version: "18" }
+ },
+
  /**
  * ESLint rules
  *
@@ -30,6 +35,7 @@ module.exports = {
  "avoidEscape": true,
  "allowTemplateLiterals": true
  }],
+ "jsx-quotes": [2, "prefer-single"],
  "no-extra-semi": 2,
  "@typescript-eslint/semi": [2],
  "comma-style": [2, "last"],
@@ -123,5 +129,8 @@ module.exports = {
  "mustMatch": "Copyright",
  "templateFile": require("path").join(__dirname, "utils", "copyright.js"),
  }],
+
+ // react
+ "react/react-in-jsx-scope": 0
  }
 };

.github/ISSUE_TEMPLATE/bug.yml

@@ -24,6 +24,7 @@ body:
  ## Make a minimal reproduction
  To file the report, you will need a GitHub repository with a minimal (but complete) example and simple/clear steps on how to reproduce the bug.
  The simpler you can make it, the more likely we are to successfully verify and fix the bug. You can create a new project with `npm init playwright@latest new-project` and then add the test code there.
+ Please make sure you only include the code and the dependencies absolutely necessary for your repro. Due to the security considerations, we can only run the code we trust. Major web frameworks are Ok to use, but smaller convenience libraries are not. 
  - type: markdown
  attributes:
  value: |

.github/actions/run-test/action.yml

@@ -36,14 +36,23 @@ runs:
  with:
  node-version: ${{ inputs.node-version }}
  - uses: ./.github/actions/enable-microphone-access
- - run: npm ci
+ - run: |
+ echo "::group::npm ci"
+ npm ci
+ echo "::endgroup::"
  shell: bash
  env:
  DEBUG: pw:install
  PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: '1'
- - run: npm run build
+ - run: |
+ echo "::group::npm run build"
+ npm run build
+ echo "::endgroup::"
  shell: bash
- - run: npx playwright install --with-deps ${{ inputs.browsers-to-install }}
+ - run: |
+ echo "::group::npx playwright install --with-deps"
+ npx playwright install --with-deps ${{ inputs.browsers-to-install }}
+ echo "::endgroup::"
  shell: bash
  - name: Run tests
  if: inputs.shell == 'bash'
@@ -69,11 +78,15 @@ runs:
  client-id: ${{ inputs.flakiness-client-id }}
  tenant-id: ${{ inputs.flakiness-tenant-id }}
  subscription-id: ${{ inputs.flakiness-subscription-id }}
- - run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json
+ - run: |
+ echo "::group::./utils/upload_flakiness_dashboard.sh"
+ ./utils/upload_flakiness_dashboard.sh ./test-results/report.json
+ echo "::endgroup::"
  if: ${{ !cancelled() }}
  shell: bash
  - name: Upload blob report
- if: ${{ !cancelled() }}
+ # We only merge reports for PRs as per .github/workflows/create_test_report.yml.
+ if: ${{ !cancelled() && github.event_name == 'pull_request' }}
  uses: ./.github/actions/upload-blob-report
  with:
  report_dir: blob-report

.github/workflows/create_test_report.yml

@@ -1,7 +1,7 @@
 name: Publish Test Results
 on:
  workflow_run:
- workflows: ["tests 1", "tests 2"]
+ workflows: ["tests 1", "tests 2", "tests others"]
  types:
  - completed
 jobs:

.github/workflows/infra.yml

@@ -44,10 +44,10 @@ jobs:
  - uses: actions/setup-node@v4
  with:
  node-version: 18
- - uses: actions/setup-python@v4
+ - uses: actions/setup-python@v5
  with:
  python-version: '3.11'
- - uses: actions/setup-dotnet@v3
+ - uses: actions/setup-dotnet@v4
  with:
  dotnet-version: 8.0.x
  - run: npm ci

.github/workflows/publish_canary.yml

@@ -14,7 +14,7 @@ env:
 jobs:
  publish-canary:
  name: "publish canary NPM"
- runs-on: ubuntu-20.04
+ runs-on: ubuntu-24.04
  if: github.repository == 'microsoft/playwright'
  permissions:
  id-token: write # This is required for OIDC login (azure/login) to succeed

.github/workflows/publish_release_docker.yml

@@ -2,12 +2,6 @@ name: "publish release - Docker"
 
 on:
  workflow_dispatch:
- inputs:
- is_release:
- required: true
- type: boolean
- description: "Is this a release image?"
-
  release:
  types: [published]
 
@@ -45,6 +39,3 @@ jobs:
  - name: Login to ACR via OIDC
  run: az acr login --name playwright
  - run: ./utils/docker/publish_docker.sh stable
- if: (github.event_name != 'workflow_dispatch' && !github.event.release.prerelease) || (github.event_name == 'workflow_dispatch' && github.event.inputs.is_release == 'true')
- - run: ./utils/docker/publish_docker.sh canary
- if: (github.event_name != 'workflow_dispatch' && github.event.release.prerelease) || (github.event_name == 'workflow_dispatch' && github.event.inputs.is_release != 'true')

.github/workflows/publish_release_driver.yml

@@ -10,7 +10,7 @@ env:
 jobs:
  publish-driver-release:
  name: "publish playwright driver to CDN"
- runs-on: ubuntu-20.04
+ runs-on: ubuntu-24.04
  if: github.repository == 'microsoft/playwright'
  permissions:
  id-token: write # This is required for OIDC login (azure/login) to succeed

.github/workflows/tests_bidi.yml

@@ -0,0 +1,46 @@
+name: tests BiDi
+
+on:
+ workflow_dispatch:
+ pull_request:
+ branches:
+ - main
+ paths:
+ - .github/workflows/tests_bidi.yml
+ schedule:
+ # Run every day at midnight
+ - cron: '0 0 * * *'
+
+env:
+ FORCE_COLOR: 1
+ ELECTRON_SKIP_BINARY_DOWNLOAD: 1
+
+jobs:
+ test_bidi:
+ name: BiDi
+ environment: ${{ github.event_name == 'push' && 'allow-uploading-flakiness-results' || null }}
+ runs-on: ubuntu-24.04
+ permissions:
+ id-token: write # This is required for OIDC login (azure/login) to succeed
+ contents: read # This is required for actions/checkout to succeed
+ strategy:
+ fail-fast: false
+ matrix:
+ channel: [bidi-chromium, bidi-firefox-nightly]
+ steps:
+ - uses: actions/checkout@v4
+ - uses: actions/setup-node@v4
+ with:
+ node-version: 20
+ - run: npm ci
+ env:
+ PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: '1'
+ - run: npm run build
+ - run: npx playwright install --with-deps chromium
+ if: matrix.channel == 'bidi-chromium'
+ - run: npx -y @puppeteer/browsers install firefox@nightly
+ if: matrix.channel == 'bidi-firefox-nightly'
+ - name: Run tests
+ run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- npm run biditest -- --project=${{ matrix.channel }}*
+ env:
+ PWTEST_USE_BIDI_EXPECTATIONS: '1'