[pull] main from microsoft:main #247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
partial fix for: #31927 (comment) The options object wasn't treated as partial, unlike in other frameworks, which led to the `component.update({ props: {} })` type being selected instead the `component.update(<Component prop={} />)` during jsx usage.
…#32219) `x-unknown` is used as a placeholder for "no content-type" in the har. We should not send it to the browser, because it is meaningfully different from not sending `Content-Type` header. For example, Chromium refuses to interpret stylesheets served with `x-unknown` content type. Fixes microsoft/playwright-java#1651.
Resolves #32218 Currently, fonts are displayed as a raw binary file which does not give any information to the users. I replaced it with a simple font preview similar to the one found in the dev tools of web browsers. It is not a major feature but I think it is a nice addition and it might be useful to somebody. <img width="1043" alt="Screenshot 2024-08-17 at 18 33 46" src="https://github.com/user-attachments/assets/a6cc7b57-7ea8-4a54-869d-57a44712597b"> https://github.com/user-attachments/assets/e52d9a72-fb2c-43c7-bfee-3d6d6edc6b6a
This PR moves around some of our CI docs. It moves the GitHub actions docs from `ci-intro.md` to `ci.md`, reduces `ci-intro.md` to be an introduction, adds a mention of Sharding to the best practices, and adds a section on `--only-changed` called "Fail-Fast". Each of those changes is a separate commit, to make this a little easier to review. If we find any of those to commits to be contentious, i'll pull them out into individual PRs. While rolling this to playwright.dev, we'll also make the following changes to its sidebar: - move the `ci.md` document from the "Integrations" section to the "Playwright Test" section - make "Best Practices" the last item of the "Getting Started" section --------- Signed-off-by: Simon Knott <info@simonknott.de> Co-authored-by: Yury Semikhatsky <yurys@chromium.org>
Closes #32159. I originally set out to enable Strict Mode for our React UI, but found a way better thing: Enabling the lint rules we had already installed! `eslint-plugin-react` is already in of our `package.json`, and this PR enables it and fixes some of the reported issues. Most of them are around the `key` prop which is mostly about performance, but there's also fixes for misspelled `data-testid` props.
Even when these are a part of a hidden `aria-labelledby` traversal, all browsers ignore them anyway.
…#32237) There is a chance in case of cross-process navigation that the navigation event comes before `navigateFrame` finishes.
… `arg` (#32240) This works with scripts bundled by: - `esbuild entrypoint.ts --bundle --format=cjs --outfile=injected.js` - webpack with a typical config ```js module.exports = { entry: { 'injected': './entrypoint.js', }, output: { path: require('path').resolve(__dirname), filename: '[name].js', libraryTarget: 'commonjs2', }, }; ```
Closes #32180 I was briefly wondering if we should output a log line a la "no tests found", but my understanding is that that's the reporters job - so I didn't change anything in that regard.
Preparation for #32076.
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Adds a test for the font preview feature.
It implements network.setCacheBehavior which should unblock some interception tests
See https://developers.google.com/privacy-sandbox/cookies/storage-partitioning for more details. References #32230.
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
With the recent Chromium fixes in v129, it is now safe to enable this feature. Fixes #31747.
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This introduces `WebSocketRoute` class and `page/context.routeWebSocket()` methods.
Signed-off-by: Max Schmitt <max@schmitt.mx> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Max Schmitt <max@schmitt.mx>
These are represented in the network pane instead.
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )