test: unflake 'should properly synchronize local and remote time' test #32733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
test-unflake-tv
branch
from
03734d2
to
dbbada5
Compare
yury-s
approved these changes
Sep 20, 2024
mxschmitt
force-pushed
the
test-unflake-tv
branch
from
dbbada5
to
0d2d77b
Compare
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"1 flaky35680 passed, 668 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run the Trace Viewer in the tests using
launchAppwhich usesnoDefaultViewport: true. Our Trace Viewer does not always render8.5s, it also renders just8.0s, based on the viewport which was given. The window size on CI is probably just 1024x720 or something like that (assumption).We could also check for
toBeLessThan.