Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: unflake 'should properly synchronize local and remote time' test #32733

Merged
merged 1 commit into from
Sep 20, 2024
+3 −1
Merged

test: unflake 'should properly synchronize local and remote time' test #32733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/library/trace-viewer.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,9 @@ test('should complain about newer version of trace in old viewer', async ({ show
test('should properly synchronize local and remote time', async ({ showTraceViewer, asset }, testInfo) => {
const traceViewer = await showTraceViewer([asset('trace-remote-time-diff.zip')]);
// The total duration should be sub 10s, rather than 16h.
await expect(traceViewer.page.locator('.timeline-time').last()).toHaveText('8.5s');
await expect.poll(async () =>
parseInt(await traceViewer.page.locator('.timeline-time').last().innerText(), 10)
).toBeLessThan(10);
});

test('should contain action info', async ({ showTraceViewer }) => {
Expand Down