staticd: Add no form for static-sids command
#18263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscarpitta
force-pushed
the
fix/add_no_form_for_static_sids_cli
branch
from
5e2eb78 to
583c140
Compare
|
looks like a srv6 test failure. Assuming it is something that needs to be addressed |
This commit converts the `static-sids` command from `DEFUN` to `DEFPY` to simplify the parsing of the command string definition. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
Currently, when the user tries to delete all static SIDs with the `no static-sids` command, staticd returns an error. ``` router# config router(config)# segment-routing router(sr)# srv6 router(srv6)# no static-sids % Unknown command: no static-sids ``` The problem is the `static-sids` command does not support the `no` form. This PR enables the `no` form for the `static-sids` command. ``` router# config router(config)# segment-routing router(sr)# srv6 router(srv6)# no static-sids ``` Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
Previous commits introduced the `no` form for the `static-sids` command. This change allow users to remove all static SIDs at once. This commit makes the `no static-sids` command available in vtysh. ``` router# config router(config)# segment-routing router(sr)# srv6 router(srv6)# no static-sids ``` Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
Add a test case to verify that staticd removes all SIDs when the `no static-sids` command is executed. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
Add a test case to verify that staticd is able to re-install all SIDs after deleting and re-adding them. Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
cscarpitta
force-pushed
the
fix/add_no_form_for_static_sids_cli
branch
from
583c140 to
641f0c6
Compare
@donaldsharp Many thanks for the review. When I committed the changes, I missed the changes in Now the PR passes all CI checks. |
|
https://github.com/Mergifyio backport dev/10.3 |
✅ Backports have been created
|
Jafaral
added a commit
that referenced
this pull request
Feb 28, 2025
staticd: Add `no` form for `static-sids` command (backport #18263)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the user tries to delete all static SIDs with the
no static-sidscommand, staticd returns an error.The problem is the
static-sidsdoes not support thenoform.This PR enables the
noform for thestatic-sidscommand.