-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FRR]: Add missing no static-sids
command
#21929
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged in FRR mainline.
Thanks for bringing the fixes in SONiC. After internal discussion, we concluded that we should keep these fixes in master for now for the safety of 202412 release. |
BTW, this PR is now using 83 index number in the series file, which will cause a conflict with the #21707 PR once that is merged. |
Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
/azp run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
Bring PR FRRouting/frr#18263 from FRR mainline to SONiC to add the missing
no static-sids
command.Currently, when the user tries to delete all static SIDs with the
no static-sids
command, staticd returns an error.The problem is the
static-sids
does not support theno
form.This PR enables the
no
form for thestatic-sids
command.