Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FRR]: Add missing no static-sids command #21929

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cscarpitta
Copy link
Contributor

@cscarpitta cscarpitta commented Mar 4, 2025

Bring PR FRRouting/frr#18263 from FRR mainline to SONiC to add the missing no static-sids command.


Currently, when the user tries to delete all static SIDs with the no static-sids command, staticd returns an error.

router# config
router(config)# segment-routing
router(sr)# srv6
router(srv6)# no static-sids
% Unknown command: no  static-sids

The problem is the static-sids does not support the no form.

This PR enables the no form for the static-sids command.

router# config
router(config)# segment-routing
router(sr)# srv6
router(srv6)# no static-sids

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
@cscarpitta cscarpitta requested a review from lguohan as a code owner March 4, 2025 23:05
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

@ahsalam ahsalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged in FRR mainline.

@ahsalam
Copy link

ahsalam commented Mar 5, 2025

@BYGX-wcr
Copy link
Contributor

BYGX-wcr commented Mar 5, 2025

@BYGX-wcr @abdosi @r12f @kperumalbfn

Thanks for bringing the fixes in SONiC. After internal discussion, we concluded that we should keep these fixes in master for now for the safety of 202412 release.

@BYGX-wcr
Copy link
Contributor

BYGX-wcr commented Mar 5, 2025

BTW, this PR is now using 83 index number in the series file, which will cause a conflict with the #21707 PR once that is merged.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cscarpitta
Copy link
Contributor Author

BTW, this PR is now using 83 index number in the series file, which will cause a conflict with the #21707 PR once that is merged.

@BYGX-wcr Many thanks for the review. I changed the index number of the patch file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants