Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceleration and Skidpad Tracks Added #266

Merged
merged 7 commits into from
Mar 9, 2021

Conversation

sgirouar5
Copy link
Contributor

Created an Acceleration map. Very simple map with no decorations.

  • Required creation of small orange cone assets including small orange cone splines.
  • Created a finish line which stops the time of the startfinish line.
  • Known Bug: All orange cones are being printed as large Orange

Created an Acceleration map. Very simple map with no decorations.

- Required creation of small orange cone assets including small orange cone splines.
- Created a finish line which stops the time of the startfinish line.
- Known Bug: All orange cones are being printed as large Orange
Added Skidpad track with no decorations. Track is based on EUFS Implementation found here: https://gitlab.com/eufs/eufs_sim/-/blob/ros2/eufs_gazebo/tracks

Required multiple splines so edited refereeBP.uasset to print out all the splines required. It should not break when doing other tracks and those references do not exist due to the ifvalid check. If there is a better way of doing it, that should be done!

Some fixes to acceleration with better cone distances  (5m)

Bug that all small orange cones are printed to ros as big orange still exists.
My changes for the referee to incorporate accel and skidpad tracks broke some references in the existing tracks. Cones were not being output to ros. Updated them so that the blue/yelow cones and start/finish line cones on all maps are now being output.
Started the documentation for map building tutorial. Please correct me if any information is wrong! Or make edits if more information should be included!

I do not know how to change the weather or daytime cycles so that section needs to be updated.


## Weather and Day Cycle Conditions
<!--Sorry I don't know how to this :/.-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry, I don't think anyone knows how to do this 🙈

@SijmenHuizenga
Copy link
Member

SijmenHuizenga commented Mar 1, 2021

Great work on this!! I'm loving every part if it 😍! The docs are great, no remarks. Ping me when the track is ready to be reviewed :)

- Added AppendSmallOrangeCone to Airsim plugin so that cones are now properly being output to ros.
- Fixed the refereeebp to reflect above.
Added some fence/wall decoration and timers on the walls.
@sgirouar5 sgirouar5 changed the title Acceleration Track Added Acceleration and Skidpad Tracks Added Mar 7, 2021
@sgirouar5
Copy link
Contributor Author

@SijmenHuizenga I think the tracks are done! I added some simple fence decorations and lap timers.

One thing to note (and this may already be why it wasn't for 2020) is that acceleration in this format should probably not be used for an online competition. Turns out you can complete the map just by pressing forward and nothing else 😅 . It is still a good test for an autonomous system if doing it honestly! A potential "competition viable fix" would be making the vehicle do a small turn before the start gate could be an option. Or even just offsetting the vehicle spawn. But this is still good for just testing the accel for an AS!

@@ -1,6 +1,6 @@
{
"FileVersion": 3,
"EngineAssociation": "4.25",
"EngineAssociation": "4.24",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for this change? Or is it an accident?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an accident. Not sure how that got changed!

Copy link
Member

@SijmenHuizenga SijmenHuizenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tracks look amazing. I did some measurements here and there and couldn't find any errors. Well done!! I'm sure a lot of people will find this very helpful. Thank you <3

Just adding some images of this beauty in action:

image
image

Before we merge one last question regarding the unreal engine version. Apart from that this is ready to be released 🚀

@SijmenHuizenga SijmenHuizenga merged commit d847ac1 into FS-Driverless:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants