Update JIMFS to 1.2 #396
Closed
Update JIMFS to 1.2 #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
requested changes
Mar 5, 2021
There was a problem hiding this comment.
Also needs updating in the installer jsons. Also needs cloning onto fabric's maven (Something I will need to do).
And yes it needs testing, im worried about this using a newer guava than what we have. Might need to make sure it doesnt pull in the wrong version.
|
Since @modmuss50 indicated in #450 (comment) that fabric will shade guava dependency with jimfs, we will probably have jimfs shade newer guava (as opposed to using outdated minecraft guava) and use that newer jimfs instead. This would become more of an issue tracking the progress. |
|
Rendered obsolete by #461 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not tested yet.