Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add a new "installerless" server launcher. #450

Closed
wants to merge 2 commits into from

Conversation

modmuss50
Copy link
Member

@modmuss50 modmuss50 commented Jun 21, 2021

This makes launching a fabric server just a matter of downloading a jar from the website or via a URl and launching it just like a normal minecraft server, without the need for an installer. This has a number of benfits:

  • Easier to people who use server hosts that expect a specific jar name, no more messing with properies files and renaming 2 jars.
  • Easier to automate as its just a matter of downloading a single jar file and running it, this will also help people that want to containerise the server. (Might be worth having an official docker container?)
  • Partly offline with no reliance on fabric's server.

Meta will provide an API to download a jar that has been marked with the minecraft server url/hash/name and the correct intermediary mappings. The website will present this in a user frieldly manner.

The old server installation method will still be supported for the time begin. Possibly start phasing it out by removing the option from the installer GUI but keep the CLI?

@modmuss50 modmuss50 requested a review from sfPlayer1 June 21, 2021 22:35
Comment on lines +74 to +75
// TODO REMOVE ME!! by shading into jimfs
required 'com.google.guava:guava:30.1.1-jre'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will setup the building of jimfs with guava shaded/repackaged in.

Copy link
Contributor

@liach liach Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And you can probably consider proguard shrink the shaded guava

In addition, shading an updated guava will allow us to update jimfs, which is quite desirable.

@liach liach mentioned this pull request Jun 22, 2021
@modmuss50
Copy link
Member Author

Going to move this into the installer, the same idea but will mean there is really only 1 load of installer logic, smaller jar files to download (easier to batch upload or generate on the fly)

@modmuss50 modmuss50 closed this Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants