Skip to content

Conversation

@FabrizioSandri
Copy link
Owner

The goal of this pull request is to fix the issue that has been discovered when using RcppDeepState to analyze the binsegRcpp package.

I discovered that if there is at least one function that cannot be analyzed, that is, a function whose arguments differ from the supported one, RcppDeepState terminates.

Fixes one of the problems found in the pull request Check rcppdeepstate #13

@tdhock
Copy link
Collaborator

tdhock commented Jul 26, 2022

can you please add a test case? maybe the easiest would be to just add a function with an unsupported type to the TestSAN package?

@FabrizioSandri
Copy link
Owner Author

FabrizioSandri commented Jul 26, 2022

@tdhock In the most recent commits I have added a new function to the testSAN package, that takes as input a parameter that isn't allowed(Rcpp::LogicalVector).

// [[Rcpp::export]]
int unsupported_datatype(Rcpp::LogicalVector param){
  return param.size();
} 

I just renamed the existing tests/testthat/test-debug-symbols.R file to tests/testthat/test-testSAN.R rather than creating a new test file. This test file simply analyzes the testSAN package and determines whether any issues have been found. It has been proved locally that RcppDeepState detects some issues when using the supplied seed number, therefore if no errors are found, something went wrong.

CI will take some time because of the other checks.

@tdhock
Copy link
Collaborator

tdhock commented Jul 26, 2022

great

@FabrizioSandri
Copy link
Owner Author

According to the new function that was added to the testSAN package, I had to update the tests. All of the checks are now successful.

@FabrizioSandri FabrizioSandri merged commit 0a91ec8 into master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants