Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Event for maintenance fees #247

Closed
ilhanu opened this issue Feb 17, 2023 · 0 comments · Fixed by #245
Closed

Add Event for maintenance fees #247

ilhanu opened this issue Feb 17, 2023 · 0 comments · Fixed by #245
Labels
enhancement New feature or request

Comments

@ilhanu
Copy link
Member

ilhanu commented Feb 17, 2023

Maintenance fees are not tracked in events. Everytime rent is payed and distributed as as a balance transfer. It would be a good metric for data collection and showing this in the front-end in the future if there is an event.

https://github.com/Fair-Squares/fair-squares/blob/main/pallets/asset_management/src/functions.rs#L325-L341
@ilhanu ilhanu added the enhancement New feature or request label Feb 17, 2023
ndkazu added a commit that referenced this issue Feb 18, 2023
@ndkazu
all points in issues #246 & #247 except voting weights
8fd7e3f
@ndkazu ndkazu linked a pull request Feb 18, 2023 that will close this issue
Updating storage RequestedRole when creating roles Seller,Servicer,etc ... #245
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating storage RequestedRole when creating roles Seller,Servicer,etc ... Fair-Squares/fair-squares
1 participant
@ilhanu