Updating storage RequestedRole when creating roles Seller,Servicer,etc ... #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhanu
approved these changes
Feb 16, 2023
This was
linked to
issues
Feb 18, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #245 +/- ##
==========================================
+ Coverage 82.62% 82.68% +0.06%
==========================================
Files 69 69
Lines 6865 6896 +31
==========================================
+ Hits 5672 5702 +30
- Misses 1193 1194 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cuteolaf
approved these changes
Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
RequestedRolesstorage was not being updated, and as a result, new roles requests (seller, servicer) were not found.I also updated the Notary role creation to use this storage, as there is currently no referendum system similar to the one used for Representatives.
One Question remains:
with the use of
RequestedRolesstorage for Approval to facilitate the front-end design,NotaryApprovalList,SellerApprovalList, andServicerApprovalListstorages are no used anymore. This needs to be clarified...