Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate FairRoot::DataMatch? #1270

Closed
ChristianTackeGSI opened this issue Nov 15, 2022 · 3 comments
Closed

Deprecate FairRoot::DataMatch? #1270

ChristianTackeGSI opened this issue Nov 15, 2022 · 3 comments
Assignees
@karabowi
Milestone
v18.8

Comments

@ChristianTackeGSI
Copy link
Member

@fuhlig1 suggests here to deprecate FairRoot::DataMatch.
@ChristianTackeGSI ChristianTackeGSI mentioned this issue Nov 15, 2022
Merged
3 tasks
@dennisklein dennisklein added the need-triage Missing milestone assignment label Nov 15, 2022
@karabowi karabowi self-assigned this Nov 16, 2022
@fuhlig1
Copy link
Member

fuhlig1 commented Nov 16, 2022

Here the answer of Tobias, so we can deprecate FairRoot::DataMatch

Hallo Florian,

die Library DataMatch kann auslaufen. Wir benutzen es nicht mehr in PandaRoot (weder über FairRoot noch über PandaRoot), da es zu langsam war.

LG,

Tobias

@ChristianTackeGSI
Copy link
Member Author

@fuhlig1 would you mind writing an appropriate ChangeLog-Entry for 18.8?

For 19 (dev) we might go the MBS way and add a BUILD_DATAMATCH option that defaults to OFF?

karabowi added a commit to karabowi/FairRoot that referenced this issue Nov 17, 2022
@karabowi
Deprecate DataMatch
f1ef494 
By default it will not be built.
Enable it by -DBUILD_DATAMATCH=ON

Addresses issue FairRootGroup#1270.
@karabowi karabowi mentioned this issue Nov 17, 2022
Merged
@karabowi karabowi removed the need-triage Missing milestone assignment label Nov 17, 2022
@karabowi karabowi added this to the v18.8 milestone Nov 17, 2022
karabowi added a commit to karabowi/FairRoot that referenced this issue Nov 17, 2022
@karabowi
Add BUILD_DATAMATCH option
c03c50a 
By default set to ON.

Addresses issue FairRootGroup#1270.
karabowi added a commit to karabowi/FairRoot that referenced this issue Nov 17, 2022
@karabowi
Deprecate DataMatch
b3fdd27 
By default it will not be built.
Enable it by -DBUILD_DATAMATCH=ON

Addresses issue FairRootGroup#1270.
karabowi added a commit to karabowi/FairRoot that referenced this issue Nov 18, 2022
@karabowi
Add BUILD_DATAMATCH build switch (default is ON)
611d3e0 
Addresses issue FairRootGroup#1270.
karabowi added a commit to karabowi/FairRoot that referenced this issue Nov 18, 2022
@karabowi
Disable and deprecate DataMatch library
d59c783 
Changed the default value of the build switch BUILD_DATAMATCH to OFF.

Addresses issue FairRootGroup#1270.
karabowi added a commit to karabowi/FairRoot that referenced this issue Nov 22, 2022
@karabowi
Deprecate DataMatch library
8ca8d8a 
Scheduled the library to be removed in a future major release of FairRoot.

Addresses issue FairRootGroup#1270.
karabowi added a commit to karabowi/FairRoot that referenced this issue Nov 22, 2022
@karabowi
Deprecate DataMatch library
1d16417 
Scheduled the library to be removed in a future major release of FairRoot.

Addresses issue FairRootGroup#1270.
dennisklein pushed a commit that referenced this issue Nov 22, 2022
@karabowi @dennisklein
Deprecate DataMatch library
da6362b 
Scheduled the library to be removed in a future major release of FairRoot.

Addresses issue #1270.
@dennisklein
Copy link
Member

wait, too fast, still needs to be picked to v18.8_patches

@dennisklein dennisklein reopened this Nov 22, 2022
dennisklein pushed a commit to dennisklein/FairRoot that referenced this issue Nov 25, 2022
@karabowi @dennisklein
Deprecate DataMatch library
c54b969 
Scheduled the library to be removed in a future major release of FairRoot.

Addresses issue FairRootGroup#1270.

(cherry picked from commit da6362b)
karabowi added a commit that referenced this issue Nov 25, 2022
@karabowi
Deprecate DataMatch library
8a75c8b 
Scheduled the library to be removed in a future major release of FairRoot.

Addresses issue #1270.

(cherry picked from commit da6362b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karabowi karabowi

Labels
None yet
Projects
None yet
Milestone
v18.8
Development

No branches or pull requests
4 participants
@dennisklein @fuhlig1 @karabowi @ChristianTackeGSI