Skip to content

Commit

Permalink
[stable/influxdb] Move bind_address under rpc header and update image…
Browse files Browse the repository at this point in the history
… to 1.7 (helm#9384)

* Update image to 1.7

Signed-off-by: Naseem Ullah <naseemkullah@gmail.com>

* move bind_address under rpc heading

Signed-off-by: Naseem Ullah <naseemkullah@gmail.com>

* Version stable, adding OWNERS, adding Upgrading in README

Signed-off-by: Naseem Ullah <naseemkullah@gmail.com>
  • Loading branch information
naseemkullah authored and coreypobrien committed Dec 31, 2018
1 parent 2622e6a commit b63f665
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 10 deletions.
4 changes: 2 additions & 2 deletions stable/influxdb/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: influxdb
version: 0.12.1
appVersion: 1.6
version: 1.0.0
appVersion: 1.7
description: Scalable datastore for metrics, events, and real-time analytics.
keywords:
- influxdb
Expand Down
4 changes: 4 additions & 0 deletions stable/influxdb/OWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
approvers:
- jackzampolin
reviewers:
- jackzampolin
6 changes: 6 additions & 0 deletions stable/influxdb/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,3 +80,9 @@ Influxdb requires also a user to be set in order for authentication to be enforc
To handle this setup on startup, a job can be enabled in `values.yaml` by setting `.Values.setDefaultUser.enabled` to `true`.

Make sure to uncomment or configure the job settings after enabling it. If a password is not set, a random password will be generated.

## Upgrading

### From < 1.0.0 To >= 1.0.0

Values `.Values.config.bind_address` and `.Values.exposeRpc` no longer exist. They have been replaced with `.Values.config.rpc.bind_address` and `.Values.config.rpc.enabled` respectively. Please adjust your values file accordingly.
2 changes: 1 addition & 1 deletion stable/influxdb/templates/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ metadata:
data:
influxdb.conf: |+
reporting-disabled = {{ .Values.config.reporting_disabled | default false }}
bind-address = ":{{ .Values.config.bind_address }}"
bind-address = ":{{ .Values.config.rpc.bind_address }}"
[meta]
dir = "{{ .Values.config.storage_directory }}/meta"
Expand Down
6 changes: 3 additions & 3 deletions stable/influxdb/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ spec:
port: {{ .Values.config.opentsdb.bind_address }}
targetPort: {{ .Values.config.opentsdb.bind_address }}
{{- end }}
{{- if .Values.exposeRpcService }}
{{- if .Values.config.rpc.enabled }}
- name: rpc
port: {{ .Values.config.bind_address }}
targetPort: {{ .Values.config.bind_address }}
port: {{ .Values.config.rpc.bind_address }}
targetPort: {{ .Values.config.rpc.bind_address }}
{{- end }}
selector:
app: {{ template "influxdb.fullname" . }}
8 changes: 4 additions & 4 deletions stable/influxdb/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
## ref: https://hub.docker.com/r/library/influxdb/tags/
image:
repo: "influxdb"
tag: "1.6-alpine"
tag: "1.7-alpine"
pullPolicy: IfNotPresent

## Specify a service type
Expand Down Expand Up @@ -117,8 +117,10 @@ env:
## ref: https://docs.influxdata.com/influxdb/v1.1/administration/config/
config:
reporting_disabled: false
bind_address: 8088
storage_directory: /var/lib/influxdb
rpc:
enabled: true
bind_address: 8088
meta:
retention_autocreate: true
logging_enabled: true
Expand Down Expand Up @@ -231,5 +233,3 @@ config:
log_enabled: true
enabled: true
run_interval: 1s

exposeRpcService: true

0 comments on commit b63f665

Please sign in to comment.