Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/influxdb] Move bind_address under rpc header and update image to 1.7 #9384

Merged
merged 3 commits into from
Dec 3, 2018
Merged

[stable/influxdb] Move bind_address under rpc header and update image to 1.7 #9384

merged 3 commits into from
Dec 3, 2018

Conversation

naseemkullah
Copy link
Collaborator

Please see title

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@naseemkullah
Update image to 1.7
1713732 
Signed-off-by: Naseem Ullah <naseemkullah@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 19, 2018
@naseemkullah naseemkullah changed the title Update image to 1.7 [stable/influxdb] Update image to 1.7 Nov 19, 2018
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 19, 2018
@naseemkullah naseemkullah changed the title [stable/influxdb] Update image to 1.7 Move bind_address under rpc header and update image to 1.7 Nov 19, 2018
@naseemkullah
Copy link
Collaborator Author

cc @jackzampolin

@naseemkullah
move bind_address under rpc heading
394123b 
Signed-off-by: Naseem Ullah <naseemkullah@gmail.com>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 19, 2018
@jackzampolin
Copy link
Contributor

Good for me! LGTM 👍

@naseemkullah naseemkullah changed the title Move bind_address under rpc header and update image to 1.7 [stable/influxdb] Move bind_address under rpc header and update image to 1.7 Nov 20, 2018
@naseemkullah
Copy link
Collaborator Author

bump

@scottrigby
Copy link
Member

@naseemkullah Just a quick note about version. Since this chart is in stable, it should be at least 1.0.0. And since this is a breaking change, would you also please add an "Upgrading" section to the README letting users know when upgrading from < 1.0.0 they'll need to change their charts values? See #5657.

Also @jackzampolin if you're added to an OWNERS file for this chart, you will be able to merge changes yourself. The best way is to create a PR adding yourself. See https://github.com/helm/charts#owning-and-maintaining-a-chart and #7446. Would you want to do this? And are there others who should be added to that?

scottrigby
scottrigby suggested changes Dec 1, 2018
View reviewed changes
Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #9384 (comment)

@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 2, 2018
@naseemkullah
Copy link
Collaborator Author

Thanks @scottrigby, the requested changes have been applied, please review and let me know if any further changes are required!

@jackzampolin I've added you as an OWNERS of this chart.

@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2018
@naseemkullah
Version stable, adding OWNERS, adding Upgrading in README
a00820f 
Signed-off-by: Naseem Ullah <naseemkullah@gmail.com>
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2018
scottrigby
scottrigby approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@scottrigby
Copy link
Member

/ok-to-test

@scottrigby
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: naseemkullah, scottrigby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2018
@k8s-ci-robot k8s-ci-robot merged commit 306747e into helm:master Dec 3, 2018
@naseemkullah naseemkullah deleted the update-influxdb-image branch December 4, 2018 12:02
yuchaoran2011 pushed a commit to yuchaoran2011/charts that referenced this pull request Dec 11, 2018
@naseemkullah @yuchaoran2011
[stable/influxdb] Move bind_address under rpc header and update image…
98e87d4 
… to 1.7 (helm#9384)

* Update image to 1.7

Signed-off-by: Naseem Ullah <naseemkullah@gmail.com>

* move bind_address under rpc heading

Signed-off-by: Naseem Ullah <naseemkullah@gmail.com>

* Version stable, adding OWNERS, adding Upgrading in README

Signed-off-by: Naseem Ullah <naseemkullah@gmail.com>
Signed-off-by: Chaoran Yu <yuchaoran2011@gmail.com>
coreypobrien pushed a commit to FairwindsOps/helm-charts that referenced this pull request Dec 31, 2018
@naseemkullah @coreypobrien
[stable/influxdb] Move bind_address under rpc header and update image…
b63f665 
… to 1.7 (helm#9384)

* Update image to 1.7

Signed-off-by: Naseem Ullah <naseemkullah@gmail.com>

* move bind_address under rpc heading

Signed-off-by: Naseem Ullah <naseemkullah@gmail.com>

* Version stable, adding OWNERS, adding Upgrading in README

Signed-off-by: Naseem Ullah <naseemkullah@gmail.com>
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
@naseemkullah @wgiddens
[stable/influxdb] Move bind_address under rpc header and update image…
2034a4d 
… to 1.7 (helm#9384)

* Update image to 1.7

Signed-off-by: Naseem Ullah <naseemkullah@gmail.com>

* move bind_address under rpc heading

Signed-off-by: Naseem Ullah <naseemkullah@gmail.com>

* Version stable, adding OWNERS, adding Upgrading in README

Signed-off-by: Naseem Ullah <naseemkullah@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scottrigby scottrigby scottrigby approved these changes

@linki linki Awaiting requested review from linki

@prydonius prydonius Awaiting requested review from prydonius

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@naseemkullah @jackzampolin @scottrigby @k8s-ci-robot @helm-bot