Building numbers can not be 0, 00, 000 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply fixes from StyleCI
Signed-off-by: Daniel Schmelz <q2CIa2U7> Co-authored-by: Daniel Schmelz <q2CIa2U7>
* Move AT payment provider logic to de_AT * Apply fixes from StyleCI * add ssn to AT Person * fix verification number generation * Apply fixes from StyleCI * Update src/Faker/Provider/de_AT/Person.php Co-authored-by: Bram Ceulemans <bramceulemans@me.com> * change formatting * Apply fixes from StyleCI * change string formatting to sprintf Signed-off-by: Daniel Schmelz <q2CIa2U7> Co-authored-by: Daniel Schmelz <q2CIa2U7> Co-authored-by: Daniel Schmelz <krsriq@users.noreply.github.com> Co-authored-by: Bram Ceulemans <bramceulemans@me.com>
* Fix typo in country names * Fix typo in abbreviated state names * Fix babel state name * Remove guesswork comment The list should be accurate now. DKI and DIY are arguable, but it's ok. * Add link to abbreviated state names * Fix wrong abbreviation from Kalut to Kaltara Co-authored-by: Asis Pattisahusiwa <pattisahusiwa@users.noreply.github.com>
* add get providers test Signed-off-by: Daniel Schmelz <daniel@schmelz.org> * renamed test function Signed-off-by: Daniel Schmelz <daniel@schmelz.org>
* add valid austrian postcodes Signed-off-by: Daniel Schmelz <daniel@schmelz.org> * change wording Signed-off-by: Daniel Schmelz <daniel@schmelz.org>
* add internet provider slug tests Signed-off-by: Daniel Schmelz <daniel@schmelz.org> * fix spacing Signed-off-by: Daniel Schmelz <daniel@schmelz.org>
* improve austrian social security number generation Signed-off-by: Daniel Schmelz <daniel@schmelz.org> * improve austrian social security number generation, add test Signed-off-by: Daniel Schmelz <daniel@schmelz.org> * change verification number test Signed-off-by: Daniel Schmelz <daniel@schmelz.org>
* move us phone numbers with extension to own method Signed-off-by: Daniel Schmelz <daniel@schmelz.org> * cleanup Signed-off-by: Daniel Schmelz <daniel@schmelz.org> * remove return type Signed-off-by: Daniel Schmelz <daniel@schmelz.org>
Signed-off-by: Daniel Schmelz <daniel@schmelz.org>
* Move AT payment provider logic to de_AT * Apply fixes from StyleCI * improved test consistency Co-authored-by: Daniel Schmelz <q2CIa2U7> Co-authored-by: Daniel Schmelz <krsriq@users.noreply.github.com>
* Run StyleCI on the entire codebase * Apply fixes from StyleCI * Enabled a bunch of phpunit fixers
* Clean up issue and PR templates * Fixed link to documentation
* add uk national insurance number Signed-off-by: Daniel Schmelz <daniel@schmelz.org> * change reference Signed-off-by: Daniel Schmelz <daniel@schmelz.org>
* Fixed en_GB national insurance number test * Lowered chance of national insurance number generation looping again
* Refactor of CONTRIBUTING.md * Remove unnecessary full path to LICENSE * Update CONTRIBUTING.md * Update CONTRIBUTING.md Co-authored-by: Graham Campbell <GrahamCampbell@users.noreply.github.com>
* avoid mt_rand usage * avoid mt_rand usage in Guessers * use int literal * use PHP_INT_MAX for big numbers * use self::numberBetween() instead
* simplify tests * use assert methods instead of comparisons
Signed-off-by: Daniel Schmelz <daniel@schmelz.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
In fzaninotto/Faker the issue that
buildingNumbermay be 0, 00 or 000 was brought up and fixed foren_US.Author's checklist
Summary of changes
This PR changes the
buildingNumberformat of all locales so that none of them can generate 0, 00 or 000 (or even 0000).Review checklist