add edge-drawing parameter-free (EDPF) preprocessor #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@geroldmeisinger I'll be a bit harsh here. I'll only add EPDF preprocessor if it has a numpy implementation. Changing current cv2 to opencv-contrib may break this node pack's compatibility. |
|
thanks for the quick answer and considering. I understand. I'll look into it. it may take a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds an edge-drawing parameter-free (EDPF) preprocessor for the following controlnet: https://civitai.com/models/149740
This is similar to ControlNet Canny but uses a modern algorithm for edge-detection which requires no parameter tuning (Canny was invented in 1986, Edge Drawing in 2012).
please note: this requires opencv-contrib as outlined here #355
it seems to work when i add opencv-contrib in requirements last (after mediapipe and albumentations add opencv). however it make break if any other custom node installs opencv afterwards. i don't know what the best way to handle this is yet.