-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDGE DRAWING LIBRARY #2314
Comments
Algorithms in the original repo and their estimated completion states after first merged commit #2313
i hope to continue working on the list below
|
@sturkmen72 Thank you so much for your integration of the Edge Drawing algorithms in OpenCV and subsequently for opencv-contrib-python! I'm using Stable Diffusion, a generative artificial intelligence software, which can turn a simple text prompt into a full blown image. Together with the ControlNet extension it is possible to "guide" the generation process based on edge maps into a specific direction. At the moment I'm training a new ControlNet based on Edge Drawing and the parameter free version already helped me a lot to increase quality of the guidance process. The first version is available on Civitai - ControlNet MySee - Edge Drawing Parameter Free and a web-demo for Edge Drawing Parameter Free, thanks to your integration. This provides a lot of value to users because it doesn't require parameter tuning like canny. This is what it looks like to most users using the Automatic1111 UI for Stable Diffusion. Left is the "ground truth" image, middle is the processed "edge map" and right is the new "generated image" based on the prompt "photo of a woman in the street, fashine, anime" and guided by the edge map to get a similar pose: I was able to compile the EDLib EDColor cpp version to generate the edge maps and the detection quality seems even better, which could further increase the quality of the ControlNet. Unfortunately, without EDColor in opencv-contrib - and therefore in Python - I'm not able to provide a web-demo for users. The EDColor version, especially a parameter free version, would be so nice. Thank you again for all your work! |
@sturkmen72 : you asked me from the EDLib repo to add context here, I am happy to do so.
|
I'm planning to train a new Controlnet with EDPF Color soon for Stable Cascade and Stable Diffusion SDXL+3 (if my hardware allows it). The Canny Controlnet is considered one of the most important Controlnets in image generation AI and thus had multiple reinstatements even though it uses the inferior canny filter, see
If edge drawing would also find it's way to the official opencv this would also allow further support in tools (my PR was denied because it is in contrib) which made me even go the javascript route just to get it into the popular ComfyUI app. |
recently i found https://github.com/CihanTopal/ED_Lib and i see it contains useful algorithms valuable to be included in OpenCV
firstly i contacted with the author and take his permission.
i want to work on code adaptation and rewriting according to OpenCV code style
test PR : #2313
The text was updated successfully, but these errors were encountered: