Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvements on EdgeDrawing #3159

Merged
merged 1 commit into from
Jan 28, 2022
Merged

improvements on EdgeDrawing #3159

merged 1 commit into from
Jan 28, 2022

Conversation

sturkmen72
Copy link
Contributor

related: #2314

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@sturkmen72 sturkmen72 marked this pull request as draft January 26, 2022 08:29
@sturkmen72 sturkmen72 force-pushed the edge_drawing branch 2 times, most recently from 8a77a6d to dff124b Compare January 26, 2022 23:50
@sturkmen72 sturkmen72 marked this pull request as ready for review January 27, 2022 07:53
@sturkmen72 sturkmen72 changed the title Update edge_drawing.cpp improvements on EdgeDrawing Jan 27, 2022
@asmorkalov asmorkalov self-requested a review January 27, 2022 09:00
@opencv-pushbot opencv-pushbot merged commit fcd5c7d into opencv:3.4 Jan 28, 2022
@sturkmen72 sturkmen72 deleted the edge_drawing branch January 28, 2022 15:38
alalek
alalek reviewed Jan 28, 2022
View reviewed changes
modules/ximgproc/include/opencv2/ximgproc/edge_drawing.hpp
//! indicates the operator used for gradient calculation.The following operation flags are available(cv::ximgproc::EdgeDrawing::GradientOperator)
/** @brief indicates the operator used for gradient calculation.

one of the flags cv::ximgproc::EdgeDrawing::GradientOperator. Default value is PREWITT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to eliminate tabs from source code.

Here and below.

@alalek alalek mentioned this pull request Jan 28, 2022
Merged
@sturkmen72 sturkmen72 mentioned this pull request Jan 28, 2022
Merged
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalek alalek alalek left review comments

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels
category: ximgproc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sturkmen72 @asmorkalov @alalek @opencv-pushbot