Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PatchAsync overload #528

Closed
mungojam opened this issue Feb 15, 2022 · 3 comments · Fixed by #536
Closed

Add PatchAsync overload #528

mungojam opened this issue Feb 15, 2022 · 3 comments · Fixed by #536
Labels
enhancement New feature or request

Comments

@mungojam
Copy link
Contributor

Is your feature request related to a problem? Please describe.
One of our APIs uses PATCH which isn't directly supported by this library.

Describe the solution you'd like
PATCH overload that would be very similar to the POST overload that already exists.

Describe alternatives you've considered
I'll use your SendAsync overload for now.

Additional context
I'll hopefully contribute more to this library in future, but lots going on at the moment. Thanks again for making it!

@mungojam mungojam added the enhancement New feature or request label Feb 15, 2022
@FantasticFiasco
Copy link
Owner

Thanks for reporting it!

Let's see if the issue gets any traction, otherwise it eventually will be implemented. I think the implementation will be easy, but we also need to update the tests to accommodate for this new feature.

@FantasticFiasco
Copy link
Owner

Unfortunately the same argumentation as this one prevents me from working on this issue.

@mungojam
Copy link
Contributor Author

mungojam commented Mar 5, 2022

Don't worry about it, it's not causing me a headache at all.

At some point I may implement both to help out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants