Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PatchAsync overloads #536

Merged

Conversation

mungojam
Copy link
Contributor

Description

I made both tests and extension methods by copying the PostAsync equivalents. In theory they could share the same underlying functionality.

I really like how your integration tests are organised. Makes it very clear.

Checklist

  • I have squashed my commits into a single one with a message that aligns with the contributing guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Simple copies from PostAsync overloads
@FantasticFiasco
Copy link
Owner

Thanks! I'll take a look at the code tomorrow, and then proceed to release a new version for you.

@mungojam
Copy link
Contributor Author

Thanks! I'll take a look at the code tomorrow, and then proceed to release a new version for you.

Thanks, I'm also working on the GetStringAsync addition. I've done the code but currently working out what to do with the tests which are more complicated than for PatchAsync. I should be able to work something out though.

@FantasticFiasco FantasticFiasco merged commit a762df6 into FantasticFiasco:master Mar 13, 2022
@mungojam mungojam deleted the patch-async-overloads branch March 13, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PatchAsync overload
2 participants