feat: Atlas v1.1 #428
Open
feat: Atlas v1.1 #428
+2,317
−1,711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: update Atlas license
Co-authored-by: Ben Sparks <52714090+BenSparksCode@users.noreply.github.com>
refactor: split most of Factory out to FactoryLib
chore: bump to Solidity 0.8.28 for `transient` keyword
0x1NotMe
approved these changes
Oct 23, 2024
| @@ -18,6 +18,8 @@ contract Storage is AtlasEvents, AtlasErrors, AtlasConstants { | |||
| address public immutable SIMULATOR; | |||
| address public immutable L2_GAS_CALCULATOR; | |||
| uint256 public immutable ESCROW_DURATION; | |||
| uint256 public immutable ATLAS_SURCHARGE_RATE; | |||
There was a problem hiding this comment.
are
ATLAS_SURCHARGE_RATE
and
keccak256("ATLAS_SOLVER_SURCHARGE");
The same maybe good to use the same string
There was a problem hiding this comment.
These are 2 different variables.
ATLAS_SURCHARGE_RATEis the percentage of gas cost we take as an Atlas surcharge, stored as an immutable variable.solverSurchargeis a transient variable, used to track the total surcharge (Atlas + Bundler) of the cost of failed solverOp gas costs, during the current metacall, if failure is the solver's fault. This has also been changed in chore: bump to Solidity 0.8.28 fortransientkeyword #442 to use the latesttransientkeyword to create thet_solverSurchargevariable instead of how it is done here, where we hash "ATLAS_SOLVER_SURCHARGE" to target a specific transient storage slot.
refactor: contract size cuts
fix: userOp graceful return gas offset
feat: add `bidAmount` to `SolverTxResult` event
feat: add indexed dapp control address in solver tx result event
feat: add surcharge settings to deploy script
feat: base deployment
feat: base sepolia deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A big bundle of updates, taking Atlas v1.0 --> Atlas v1.1
Changes:
returnDatato solvers #419userOp.gasas userOp's gas limit #420Escrow.t.solhook input and revert tests #430Additional PRs to cut contract size: