Improve Escrow.t.sol hook input and revert tests
#430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jj1980a
reviewed
Sep 18, 2024
test/base/DummyDAppControl.sol
Outdated
| @@ -21,6 +21,14 @@ contract DummyDAppControl is DAppControl { | |||
| bool public allocateValueShouldRevert; | |||
| bool public postOpsShouldRevert; | |||
|
|
|||
| // TODO add storage vars to store input data for each hook, then test hooks were passed the correct data | |||
There was a problem hiding this comment.
Oof yes it is. Will remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
userOp.dataencoded input, with the logic in the DummyDAppControl that determines if a hook reverts or not.