Re-enable setting of final instance fields #5150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@stevenschlansker We also have Oh well, on short term let's just do this to unblock. Thanks! |
Contributor
Author
|
I hope this fixes all outstanding issues. Please let me know if you find more 😄 |
Member
|
@stevenschlansker All went well as far as I can see, and specifically Kotlin & Scala modules were re-built without further failures! So I think we are good to go wrt this feature! |
Contributor
Author
|
Fantastic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out this is currently necessary for Scala and Kotlin data classes.
Mutating
finalfields will still eventually go away once the JVM forbids it, but we don't necessarily have to force the issue now.Followup to #5090