Skip to content

Re-enable setting of final instance fields #5150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cowtowncoder merged 1 commit into from
May 9, 2025
Merged

Re-enable setting of final instance fields #5150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/main/java/tools/jackson/databind/deser/BeanDeserializerFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,10 +939,6 @@ protected SettableBeanProperty constructSettableProperty(DeserializationContext
JavaType type = resolveMemberAndTypeAnnotations(ctxt, mutator, propType0);
// Does the Method specify the deserializer to use? If so, let's use it.
TypeDeserializer typeDeser = (TypeDeserializer) type.getTypeHandler();
// 05-May-2025, tatu: [databind#5090]/[databind#2083] Need to skip these for some reason
if (isFinalField(mutator)) {
return null;
}
ValueDeserializer<?> deser = findDeserializerFromAnnotation(ctxt, mutator);
if (deser == null) {
deser = (ValueDeserializer<?>) type.getValueHandler();
Expand All @@ -965,11 +961,6 @@ protected SettableBeanProperty constructSettableProperty(DeserializationContext
return prop;
}

private boolean isFinalField(AnnotatedMember am) {
return am instanceof AnnotatedField
&& Modifier.isFinal(am.getMember().getModifiers());
}

/**
* Method that will construct a regular bean property setter using
* the given setter method.
Expand Down