-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update repo name and location for acoustic messages #269
Update repo name and location for acoustic messages #269
Conversation
In order to future-proof this, you may want to use a specific tag or commit for the marine_msgs repo, rather than having it use |
Might fix errors like this one on 😅 I got confused in that issue, because now there's another package that's been released and called Is I don't have a setup to test it anymore. I don't know if anybody has at this point. So I don't know if we'll be merging PRs. (I could try to make time, but no guarantees.) |
@mabelzhang -- just a note that I'm at sea, and will be getting home late August. I tried (and failed) to get marine_acoustic_msgs properly released before I left, so it's close to the top of my stack for when I get home.
Correct. |
Thanks for the quick reply! I wonder if you could create stub packages with the old name, and have package.xml that install the new packages. That way, it is backward compatible and won't break people who have been using the APL repo. For example, upstream, we had to change the names for a lot of packages during the Ignition->Gazebo rename, and that could have broken a lot of people. But we did it in a way that didn't. (Not that I'm making a selfish suggestion because we aren't actively maintaining this repo 😅 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
Could you change the version:main
to version: tags/v2.0.0
? This way we can fix it to the v2.0.0 tag for future-proof
While it gies Head Detached warning, it works.
Ooh that's a good idea. |
This addresses #268.