feat: add custom splitlines to avoid line splitting on text formatter #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavienSindou
requested review from
richard-julien,
Megafredo,
Powlinett and
helene-nguyen
Powlinett
approved these changes
Oct 28, 2024
flavienSindou
deleted the
issue/fix-unescaped-newline-chars-crop-message
branch
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where certain characters are interpreted as newline characters by str.splitlines, causing SSE messages to be incorrectly split and resulting in incomplete messages.
see https://docs.python.org/3.11/library/stdtypes.html#str.splitlines
This issue is outlined in
FiligranHQ/filigran-sseclient#1 thanks to unsub42.
To resolve this, we implemented a custom splitlines method that splits lines based strictly on a defined set of newline characters.