Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update sse-client to handle newline character #795

Merged
merged 2 commits into from
Dec 17, 2024
Merged

feat: update sse-client to handle newline character #795

merged 2 commits into from
Dec 17, 2024

Conversation

flavienSindou
Copy link
Contributor

@flavienSindou flavienSindou commented Dec 9, 2024 •
edited
Loading

Proposed changes

  • upgrade SSE client version to add newline splitting patch

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • [] I wrote test cases for the relevant uses case
  • [] I added/update the relevant documentation (either on github or on notion)
  • [] Where necessary I refactored code to improve the overall quality

Related task with end to end error reproduction steps:

https://www.notion.so/filigran/SSE-client-encoding-1288fce17f2a802f9fecd23e09cde2d5?pvs=4#1288fce17f2a800296aad8bd48b31a0b

@flavienSindou flavienSindou self-assigned this Dec 9, 2024
@flavienSindou flavienSindou changed the title feat: update sse-cloent to handle newline character feat: update sse-client to handle newline character Dec 9, 2024
@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Dec 10, 2024
@flavienSindou flavienSindou merged commit 711f3a9 into master Dec 17, 2024
6 checks passed
@flavienSindou flavienSindou deleted the connectors/issue/3061 branch December 17, 2024 09:25
@flavienSindou flavienSindou mentioned this pull request Dec 17, 2024
Closed
@flavienSindou flavienSindou mentioned this pull request Dec 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Powlinett Powlinett Powlinett approved these changes

@Megafredo Megafredo Awaiting requested review from Megafredo

Assignees

@flavienSindou flavienSindou

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flavienSindou @Powlinett @SouadHadjiat