adds urls for subs-graphql #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+317
to
+318
| 'subs-graphql': /^https:\/\/(beta-)?api\.ft\.com\/subs\/query\/api\//, | ||
| 'subs-graphql-test': /^https:\/\/(beta-)?api-t\.ft\.com\/subs\/query\/api\//, |
There was a problem hiding this comment.
Note: Just a thought for the future, when you convert some of the queries into canned queries it might be worth updating this to have a regex that matches specific canned queries so its easier to tell from the metrics the performance of individual canned queries.
Something like this
'subs-graphql-{query-name}': /^https:\/\/(beta-)?api\.ft\.com\/subs\/query\/api\/{query-name}/,
Where {query-name} is replaced in the key name and regex with the actual query name
There was a problem hiding this comment.
Yeah, great point
GlynnPhillips
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the subs-graphql endpoints (test and prod) to the services
Usage in next-retention