Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds urls for subs-graphql #525

Merged
merged 1 commit into from
Sep 20, 2023
Merged

adds urls for subs-graphql #525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/metrics/services.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,8 @@ module.exports = {
'subscriptions-api-test': /^https:\/\/(beta-)?api-t\.ft\.com\/transitions\/subscriptions\//,
'subscriptions-api-transitions': /^https:\/\/(beta-)?api\.ft\.com\/subs\/transitions\//,
'subscriptions-api-transitions-test': /^https:\/\/(beta-)?api-t\.ft\.com\/subs\/transitions\//,
'subs-graphql': /^https:\/\/(beta-)?api\.ft\.com\/subs\/query\/api\//,
'subs-graphql-test': /^https:\/\/(beta-)?api-t\.ft\.com\/subs\/query\/api\//,
Comment on lines +317 to +318
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Just a thought for the future, when you convert some of the queries into canned queries it might be worth updating this to have a regex that matches specific canned queries so its easier to tell from the metrics the performance of individual canned queries.

Something like this

'subs-graphql-{query-name}': /^https:\/\/(beta-)?api\.ft\.com\/subs\/query\/api\/{query-name}/,

Where {query-name} is replaced in the key name and regex with the actual query name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, great point

'tag-facets-api': /^https?:\/\/tag-facets-api\.ft\.com/,
'temporize': /^https:\/\/api\.temporize\.net\//,
'tls-check-memb': /^https:\/\/howsmyssl\.memb\.ft\.com\/a\/check/,
Expand Down