Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the value receiver instead of the pointer receiver in Pubkey.Identity() (Triage on ostracon#492) #10

Closed
Tracked by #1
0Tech opened this issue Nov 1, 2023 · 1 comment
Assignees

Comments

@0Tech
Copy link

0Tech commented Nov 1, 2023

The subject of the triage:

@Mdaiki0730
Copy link
Member

It seems that crypto/composite/composite.go does not exist at the stage of v0.38.0.
https://github.com/cometbft/cometbft/tree/v0.38.0/crypto

crypto/composite/composite.go was experimentally introduced in ostracon#194 for BLS signatures and removed in ostracon#541.
Finschia/ostracon#194
Finschia/ostracon#541

It seems that there is no need to reflect it in cometbft.

@Mdaiki0730 Mdaiki0730 changed the title Triage on ostracon#492 Use the value receiver instead of the pointer receiver in Pubkey.Identity() (Triage on ostracon#492) Nov 6, 2023
@0Tech 0Tech closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants