-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove BLS functionality from the mainstream #541
Remove BLS functionality from the mainstream #541
Conversation
- Definition of BLS key and composite key. - Fields and procedures related to BLS signature aggregation in struct and ProtocolBuffers. - Identifiers used to identify the type of key. - Size or hash value of the structure being tested.
5565e19
to
438bb06
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #541 +/- ##
==========================================
- Coverage 66.30% 66.24% -0.06%
==========================================
Files 281 279 -2
Lines 38170 37593 -577
==========================================
- Hits 25307 24904 -403
+ Misses 11053 10920 -133
+ Partials 1810 1769 -41
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the PR of #335 also needs to revert. The others look good to me.
I'm reverting to the draft because Ostracon documents also need to be corrected. |
a6c2bfe
to
32e705e
Compare
32e705e
to
7ccf0fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR removes the BLS functionality from the Ostracon mainstream.
Problem settings
There are unresolved issues with signature aggregation in the current Tendermint design. Ostracon has struggled with this issue for a long time, but to improve source compatibility with Tendermint v0.34.19, we are removing support for the BLS key and its signature aggregation until a plan can be developed to avoid this issue.
The followings are a summary of the problems with applying BLS and other signature aggregation algorithm to Ostracon (and Tendermint).
Changes
This PR removes the BLS functionality from Ostracon and the same time indicates where Tendermint needs to be modified to support signature aggregation and different key algorithms on the same blockchain instance.
The following external interfaces are affected by this change.
--priv_key_type
has been removed from allostracon
subcommands such asinit
.CompositePubKey
type andCommit.aggregated_signature
field are removed.More internally, the following relevant codes are removed or changed.
The following points are helpful when reintroducing the BLS signature algorithms or other ones.
bls12381
.CompositeKey
is fine, but thecomposite
specified in the command-line option should be changed to an algorithm name such asbls
.Closes: #XXX