-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ostracon/main based on Tendermint v0.34.8 #194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torao
force-pushed
the
apply_v0.34.8
branch
2 times, most recently
from
April 5, 2021 09:01
9c3dcb5
to
efd45b1
Compare
torao
force-pushed
the
apply_v0.34.8
branch
4 times, most recently
from
April 21, 2021 08:28
204e82d
to
cf662fb
Compare
torao
force-pushed
the
apply_v0.34.8
branch
3 times, most recently
from
April 30, 2021 09:57
2dafb55
to
b8261cf
Compare
…ult to apply VRF)
Kynea0b
suggested changes
Jun 30, 2021
This folder |
tnasu
reviewed
Jun 30, 2021
tnasu
reviewed
Jun 30, 2021
torao
commented
Jul 1, 2021
tnasu
requested changes
Jul 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I finished the first review. Please check my comments include nit feedbacks.
For building, could you patch the below? (Using 1.15-alpine)
Ref:
|
tnasu
requested changes
Jul 2, 2021
torao
force-pushed
the
apply_v0.34.8
branch
2 times, most recently
from
July 2, 2021 08:37
0eb453f
to
76eab22
Compare
Kynea0b
approved these changes
Jul 2, 2021
LGTM |
tnasu
requested changes
Jul 2, 2021
tnasu
approved these changes
Jul 5, 2021
tnasu
referenced
this pull request
in tnasu/ostracon
Dec 12, 2022
tnasu
added a commit
that referenced
this pull request
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
This PR migrates all previous changes and fixes of Ostracon (formerly LINE Blockchain) applied in Tendermint v0.33.x to
ostracon/main
, which is based on Tendermint v0.34.8. In addition to Tendermint v0.34.8, Ostracon introduces or fixes the following features:Note for reviewers:
For contributor use:
Wrote testsUpdated CHANGELOG_PENDING.mdLinked to Github issue with discussion and accepted design OR link to spec that describes this work.Updated relevant documentation (docs/
) and code commentsFiles changed
in the Github PR explorer