Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ZKAuthMsgDecorator anteHandler for zkauth #1246

Merged
merged 21 commits into from
Mar 5, 2024
Merged

feat: add ZKAuthMsgDecorator anteHandler for zkauth #1246

merged 21 commits into from
Mar 5, 2024
+1,141 −165

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Feb 21, 2024 •
edited
Loading

Description

related: #1229

  • Add ZKAuthMsgDecorator antehandler for zkauth. ZKAuthMsgDecorator verify the zkp proof of zkauth message if included message is zkauth message.
  • Add new AnteHandler set for simapp
  • Change max_block_height type of ZKAuthSignature to int64
  • Modify JWK patch - no save and add RWMutex
  • Add zkauth address converting function - zkauth/types/address.go
  • Add ZKAuthSignature verification

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue self-assigned this Feb 21, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.80831% with 213 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (feat/zkauth@6929a1d). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             feat/zkauth    #1246   +/-   ##
==============================================
  Coverage               ?   69.63%           
==============================================
  Files                  ?      659           
  Lines                  ?    68192           
  Branches               ?        0           
==============================================
  Hits                   ?    47486           
  Misses                 ?    18469           
  Partials               ?     2237
Files Coverage Δ
simapp/app.go 82.66% <100.00%> (ø)
x/zkauth/types/config.go 0.00% <ø> (ø)
x/zkauth/keeper/keeper.go 69.01% <75.00%> (ø)
simapp/ante/ante.go 70.00% <70.00%> (ø)
x/zkauth/ante/zkauth.go 70.00% <70.00%> (ø)
x/zkauth/types/address.go 70.96% <70.96%> (ø)
x/zkauth/types/zkauth_verify.go 50.00% <50.00%> (ø)
x/zkauth/types/msgs.go 36.76% <50.00%> (ø)
x/zkauth/types/zkauth_inputs.go 57.76% <30.23%> (ø)
x/zkauth/types/jwks.go 36.84% <36.84%> (ø)
... and 1 more

@zemyblue
feat: add jwk types and unittests(TestVerifyZKAuthSignature)
e83e47c
@zemyblue
fix: typo and lint warning.
991292b
@zemyblue
fix: typo and lint warning.
f9c02bc
@zemyblue
chore: add ZKAuthMsgDecorator AnteHandler unittest.
7212e35
@zemyblue
fix: invalid memory address
a23618a
@zemyblue
fix: DATA RACE
3518083
@zemyblue
fix: lint errors
6e90700
@zemyblue
fix: DATA RACE
f54b38c
@zemyblue
feat: add app antehandler and zkauth msg unittest
22934fc
@zemyblue
fix ci error
164d0b5
@zemyblue
chore: add a unittest of appante.NewAnteHandler
f07516b
@zemyblue
Merge branch 'feat/zkauth' into feat/zkauth_antehandler
fdae67a 
* feat/zkauth:
  feat: implement dispatch msg (Finschia#1247)

# Conflicts:
#	x/zkauth/keeper/keeper.go
#	x/zkauth/keeper/keeper_test.go
#	x/zkauth/testutil/keeper.go
#	x/zkauth/types/msgs.go
#	x/zkauth/types/tx.pb.go
@zemyblue
feat: add zkaddress calculation function
15bf1f1
@zemyblue
fix: lint error
7891005
@zemyblue
chore: fix unittest error
c9c70f8
@zemyblue
fix: lint error and address unittest error
adda001
@zemyblue
chore: Comment out the test code.
a6cb768
zemyblue
zemyblue commented Feb 28, 2024
View reviewed changes
simapp/ante/ante_test.go Outdated Show resolved Hide resolved
simapp/app.go Show resolved Hide resolved
@zemyblue zemyblue marked this pull request as ready for review February 28, 2024 09:10
@zemyblue zemyblue mentioned this pull request Feb 28, 2024
Open
@zemyblue zemyblue mentioned this pull request Feb 28, 2024
Open
Mdaiki0730
Mdaiki0730 reviewed Mar 1, 2024
View reviewed changes
simapp/app.go Show resolved Hide resolved
simapp/app.go Show resolved Hide resolved
x/zkauth/keeper/keeper.go Show resolved Hide resolved
@zemyblue zemyblue requested a review from Mdaiki0730 March 4, 2024 08:40
@zemyblue zemyblue merged commit ca6ca76 into Finschia:feat/zkauth Mar 5, 2024
32 checks passed
@zemyblue zemyblue deleted the feat/zkauth_antehandler branch March 5, 2024 03:58
@zemyblue zemyblue mentioned this pull request Mar 6, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mdaiki0730 Mdaiki0730 Mdaiki0730 approved these changes

@shiki-tak shiki-tak Awaiting requested review from shiki-tak

@tkxkd0159 tkxkd0159 Awaiting requested review from tkxkd0159 tkxkd0159 is a code owner

@0Tech 0Tech Awaiting requested review from 0Tech 0Tech is a code owner

@jaeseung-bae jaeseung-bae Awaiting requested review from jaeseung-bae

Assignees

@zemyblue zemyblue

Labels
C:x/zkauth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zemyblue @Mdaiki0730