fix: Remove creation of the extra check and add support for GAC paths #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This implementation partially overlaps with #299. This implementation is more user friendly IMHO. Letting to use the input parameter to provide either the path to GAC or GAC info allows to support already configured workflows and also to use this action with |
|
@jhuleatt I'd recommend to release it as |
jhuleatt
reviewed
May 24, 2024
jhuleatt
requested changes
May 24, 2024
refactor code to stop creating an empty action. refactor code to move deploy code to stand alone methods. change log severity to report errors. add extra info logs to improve verbosity of the action.
Co-authored-by: Jeff <3759507+jhuleatt@users.noreply.github.com>
Co-authored-by: Jeff <3759507+jhuleatt@users.noreply.github.com>
Co-authored-by: Jeff <3759507+jhuleatt@users.noreply.github.com>
Throw an error if `firebase.json` is missing. Print a neutral tracking log after processing GAC info
because rebasing was complex the implementation of disableComment parameter had to be fixed.
|
Closing PR due to lack of activity. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes creation of the additional action when this action is executed.
Modifies the processing of GAC credentials to allow passing to the
firebaseServiceAccountparameter both the path to the SA key as well as the JSON with credentials.Continues execution in absence of the
firebase.jsonfile to support "default" settings.Deletes the temporary file with credentials when it is created due to passing the credentials data in the
firebaseServiceAccountparameter.Refactors log output to provide some more information and minimize the number of log groups.
Updates README with additional paragraph that references a user to keyless authentication action.
Refactors code to improve readability.