fix: Avoid infinite render on value change (#524)

addon/adapters/firebase.js

@@ -3,7 +3,8 @@ import DS from 'ember-data';
 import Waitable from '../mixins/waitable';
 import toPromise from '../utils/to-promise';
 
-const { assign, RSVP: { Promise } } = Ember;
+const { assign, RSVP } = Ember;
+const { Promise } = RSVP;
 
 var uniq = function (arr) {
   var ret = Ember.A();
@@ -125,26 +126,15 @@ export default DS.Adapter.extend(Waitable, {
 
 
   /**
-   * Promise interface for once('value') that also handle test waiters.
+   * Promise interface for once('value').
    *
    * @param  {Firebase} ref
    * @param  {String} log
    * @return {Promise<DataSnapshot>}
    * @private
    */
   _fetch(ref, log) {
-    this._incrementWaiters();
-    return new Promise((resolve, reject) => {
-
-      ref.once('value', (snapshot) => {
-        this._decrementWaiters();
-        Ember.run(null, resolve, snapshot);
-      }, (err) => {
-        this._decrementWaiters();
-        Ember.run(null, reject, err);
-      });
-
-    }, log);
+    return RSVP.resolve(ref.once('value'), log);
   },
 
 

tests/acceptance/live-connection-test.js

@@ -0,0 +1,28 @@
+import { expect } from 'chai';
+import startApp from '../helpers/start-app';
+import destroyApp from '../helpers/destroy-app';
+
+import {
+  describe,
+  it,
+  beforeEach,
+  afterEach,
+} from 'mocha';
+
+describe('Acceptance: live firebase connection', function () {
+  beforeEach(function () {
+    this.application = startApp();
+  });
+
+  afterEach(function () {
+    destroyApp(this.application);
+  });
+
+  it('handles live connections in testing', function () {
+    visit('/posts');
+
+    andThen(function () {
+      expect(currentPath()).to.equal('posts.index');
+    });
+  });
+});

tests/integration/finding-records-test.js

@@ -77,10 +77,6 @@ describe('Integration: FirebaseAdapter - Finding Records', function() {
       expect(findRef.toString()).to.match(/blogs\/normalized\/posts\/post_1$/g);
     });
 
-    it('returns an object', function() {
-      expect(findPromise).to.be.an('object');
-    });
-
     it('returns a promise', function() {
       expect(findPromise.then).to.be.a('function');
     });
@@ -134,10 +130,6 @@ describe('Integration: FirebaseAdapter - Finding Records', function() {
       expect(findAllRef.toString()).to.match(/blogs\/normalized\/posts$/g);
     });
 
-    it('returns an object', function() {
-      expect(findAllPromise).to.be.an('object');
-    });
-
     it('returns a promise', function() {
       expect(findAllPromise.then).to.be.a('function');
     });