Avoid infinite render on value change

[steven-ferguson]

Fixes #480 . Looks like the issue was closed even though a fix was never merged.

[jamesdaniels]

We had to roll this back, due to #484. Any thoughts on how to fix the render + not break acceptance tests?

[steven-ferguson]

I had not seen that issue thanks for linking. One thing I am having trouble understanding is why we are not just returning ref.once('value') as a promise from _fetch:

_fetch(ref) {
  return ref.once('value');
}

[steven-ferguson]

I have added a test which connects to a live firebase since that seems to be where the run loop issues were coming from. This test failed as expected with my initial commit, and now passes when only returning the promise from ref.once('value').

[tstirrat]

The log input param is not used. Try this:

return Promise.resolve(ref.once('value'), log);

[steven-ferguson]

Ok updated. Let me know if you want to squash this down to one commit.

[jamesdaniels]

We can squash from the pull request. Tests are red though @steven-ferguson can you take a peek?

[steven-ferguson]

I was not able to reproduce the failures on my local machine. Would you mind kicking the build off again?

[tstirrat]

I kicked it off again, let's see how that goes.

[tstirrat]

Pushing out a release, btw.