-
Notifications
You must be signed in to change notification settings - Fork 954
fix: generate TOML commands for Qwen Code #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes introduce a unified TOML-based infrastructure for slash command configurators. A new abstract Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant Configurator as Concrete Configurator<br/>(Gemini/Qwen)
participant Base as TomlSlashCommandConfigurator
participant FS as File System
Caller->>Configurator: generateAll()
Configurator->>Base: generateAll()
loop for each target
Base->>FS: file exists?
alt File exists
Base->>FS: read file
Base->>Base: updateBody()<br/>validate & replace<br/>OpenSpec markers
Base->>FS: write updated file
else File not found
Configurator->>Base: getDescription(id)
Configurator->>Configurator: compute body
Base->>Base: generateTOML()<br/>format with description<br/>& prompt block
Base->>FS: write new TOML file
end
Base->>Base: collect file path
end
Base-->>Caller: return touched paths
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
🧰 Additional context used🧬 Code graph analysis (1)src/core/configurators/slash/toml-base.ts (2)
🔇 Additional comments (16)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
1 similar comment
✅ Actions performedReview triggered.
|
Fixes #293. Qwen Code requires TOML format for custom commands. This PR updates the Qwen configurator to generate TOML files instead of Markdown, reusing logic from the Gemini configurator.
Summary by CodeRabbit
Release Notes