fix: Types not being exported and autocomplete not working #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagoapolo
commented
Jan 20, 2025
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "flagsmith", | |||
| "version": "9.0.0", | |||
| "version": "9.0.1", | |||
There was a problem hiding this comment.
Heads up that I increased the patch version
There was a problem hiding this comment.
Right now you have to keep react-native's inline too
kyle-ssg
approved these changes
Jan 20, 2025
| @@ -1,6 +1,7 @@ | |||
| import { IFlagsmith } from './types'; | |||
| declare const flagsmith: IFlagsmith; | |||
| export default flagsmith; | |||
| export * from './types'; | |||
There was a problem hiding this comment.
I'd love to understand the use of the wildcard export here. In a python context, whenever I see an import *, it's an immediate red flag, but maybe that's not the case here because /types explicitly defines what it wants to export I suppose?
There was a problem hiding this comment.
This'll basically mean we can import anything that was exported in types directly from flagsmith, i.e. it'll let us do
import { IInitConfig, IState } from 'flagsmith';
rather than need to do
import { IInitConfig, IState } from 'flagsmith/types';
It's an improvement rather than a fix to the original issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following problems:
Types are found in 'react.d.ts', but this result could not be resolved when respecting package.json "exports")Cannot find module './evaluation-context' or its corresponding type declarations.Cannot find module './evaluation-context' or its corresponding type declarations. #283