-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Types not being exported and autocomplete not working #284
Merged
+14
−8
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"name": "flagsmith", | ||
"version": "9.0.0", | ||
"version": "9.0.1", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Heads up that I increased the patch version There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Right now you have to keep react-native's inline too |
||
"description": "Feature flagging to support continuous development", | ||
"main": "./index.js", | ||
"module": "./index.mjs", | ||
|
@@ -10,22 +10,26 @@ | |
".": { | ||
"import": "./index.mjs", | ||
"require": "./index.js", | ||
"browser": "./index.js" | ||
"browser": "./index.js", | ||
"types": "./index.d.ts" | ||
}, | ||
"./isomorphic": { | ||
"import": "./isomorphic.mjs", | ||
"require": "./isomorphic.js", | ||
"browser": "./isomorphic.js" | ||
"browser": "./isomorphic.js", | ||
"types": "./isomorphic.d.ts" | ||
}, | ||
"./react": { | ||
"import": "./react.mjs", | ||
"require": "./react.js", | ||
"browser": "./react.js" | ||
"browser": "./react.js", | ||
"types": "./react.d.ts" | ||
}, | ||
"./next-middleware": { | ||
"import": "./next-middleware.mjs", | ||
"require": "./next-middleware.js", | ||
"browser": "./next-middleware.js" | ||
"browser": "./next-middleware.js", | ||
"types": "./next-middleware.d.ts" | ||
} | ||
}, | ||
"repository": { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to understand the use of the wildcard export here. In a python context, whenever I see an
import *
, it's an immediate red flag, but maybe that's not the case here because/types
explicitly defines what it wants to export I suppose?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This'll basically mean we can import anything that was exported in types directly from flagsmith, i.e. it'll let us do
rather than need to do
It's an improvement rather than a fix to the original issue.