Skip to content

Commit

Permalink
fix: cancelCommandRuns should works independent (#1405)
Browse files Browse the repository at this point in the history
Fixes #1403 

## Test Plan
> How do we know the code works?

### I case

1. If exist remove ```test_runner/results```
1. run only ```CancelCommandTest.cancelCommandRuns``` test
1. Test should pass

### II case

1. If exist remove ```test_runner/results```
1. run ```./gradlew check```
1. Test should pass

### III case

1. You should have ```test_runner/results``` with some subdirectories with test results
1. Check ```test_runner/results``` contains ```a``` directory without ```matrix_ids.json```. This directory cause problem on Ubuntu workflow. Remove rest of directories (```test_runner/results``` should contain only ```a``` directory)
1. run only ```CancelCommandTest.cancelCommandRuns``` test
1. Test should pass

- [x] Ubuntu workflow should pass
  • Loading branch information
adamfilipow92 authored Dec 16, 2020
1 parent 81bf670 commit d676bbd
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ class CancelCommandTest {

@Test
fun cancelCommandRuns() {
CancelCommand().run()
val runCmd = AndroidRunCommand()
runCmd.configPath = "./src/test/kotlin/ftl/fixtures/simple-android-flank.yml"
runCmd.run()
Expand Down

0 comments on commit d676bbd

Please sign in to comment.