Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cancelCommandRuns should works independent #1405

Merged
merged 1 commit into from
Dec 16, 2020
Merged

fix: cancelCommandRuns should works independent #1405

merged 1 commit into from
Dec 16, 2020

Conversation

adamfilipow92
Copy link
Contributor

@adamfilipow92 adamfilipow92 commented Dec 16, 2020 •
edited
Loading

Fixes #1403

Test Plan

How do we know the code works?

I case

  1. If exist remove test_runner/results
  2. run only CancelCommandTest.cancelCommandRuns test
  3. Test should pass

II case

  1. If exist remove test_runner/results
  2. run ./gradlew check
  3. Test should pass

III case

  1. You should have test_runner/results with some subdirectories with test results
  2. Check test_runner/results contains a directory without matrix_ids.json. This directory cause problem on Ubuntu workflow. Remove rest of directories (test_runner/results should contain only a directory)
  3. run only CancelCommandTest.cancelCommandRuns test
  4. Test should pass
  • Ubuntu workflow should pass

@adamfilipow92 adamfilipow92 self-assigned this Dec 16, 2020
@github-actions
Copy link
Contributor

Timestamp: 2020-12-16 13:57:26
Buildscan url for ubuntu-workflow run 425780615
https://gradle.com/s/6p7l4w5vi3z4a

Sloox
Sloox approved these changes Dec 16, 2020
View reviewed changes
test_runner/src/test/kotlin/ftl/cli/firebase/CancelCommandTest.kt
@@ -43,7 +43,6 @@ class CancelCommandTest {

@Test
fun cancelCommandRuns() {
CancelCommand().run()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change ;)

@mergify mergify bot merged commit d676bbd into master Dec 16, 2020
@mergify mergify bot deleted the 1403-fix-failing-tests branch December 16, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@Sloox Sloox Sloox approved these changes

@zuziaka zuziaka Awaiting requested review from zuziaka

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@jan-goral jan-goral Awaiting requested review from jan-goral

@piotradamczyk5 piotradamczyk5 Awaiting requested review from piotradamczyk5

Assignees

@Sloox Sloox

@adamfilipow92 adamfilipow92

Labels
Bug Tech Debt Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CancelCommandTest is failing on ubuntu workflow
3 participants
@adamfilipow92 @Sloox @pawelpasterz