Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supported version ids for device printed not correctly #1328

Closed
adamfilipow92 opened this issue Nov 17, 2020 · 0 comments · Fixed by #1338
Closed

Supported version ids for device printed not correctly #1328

adamfilipow92 opened this issue Nov 17, 2020 · 0 comments · Fixed by #1338
Assignees
@adamfilipow92
Labels
Bug Tiger 🐯

Comments

@adamfilipow92
Copy link
Contributor

Describe the bug

A clear and concise description of what the bug is.

When a user try to use the device with an unsupported API level flank prints message


Incompatible model, 'OnePlus5', and version, '28'
Supported version ids for 'OnePlus5': ftl.android.IncompatibleModelVersion@1fde0371

To Reproduce

Steps to reproduce the behavior:

  1. Run flank with the device configured with unsupported API level like

  device:
    - model: OnePlus5
      version: 28
  1. See error

Incompatible model, 'OnePlus5', and version, '28'
Supported version ids for 'OnePlus5': ftl.android.IncompatibleModelVersion@1fde0371

Expected behavior

A clear and concise description of what you expected to happen.

Flank should print supported versions correctly.

Details (please complete the following information):

Have you tested on the latest Flank snapshot?

Post the output of flank --version.

Latest master
@adamfilipow92 adamfilipow92 self-assigned this Nov 19, 2020
@adamfilipow92 adamfilipow92 mentioned this issue Nov 19, 2020
Merged
3 tasks
@mergify mergify bot closed this as completed in #1338 Nov 20, 2020
mergify bot pushed a commit that referenced this issue Nov 20, 2020
@adamfilipow92
fix: Fix printing supported versions id (#1338)
0c87150 
Fixes #1328 

## Test Plan
> How do we know the code works?

1. Run Flank with a configured device with not supported API level

```
  device:
    - model: OnePlus6T
      version: 19

```

or if you want to check how the message looks when we have more than one supported version

```

  device:
    - model: Nexus7
      version: 28

```

2. Error message should look like:

```

Incompatible model, 'OnePlus6T', and version, '19'
Supported version ids for 'OnePlus6T': 28


```


## Checklist

- [X] Fix printing on android
- [x] Verification and fix iOs
- [X] Unit tested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamfilipow92 adamfilipow92

Labels
Bug Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix printing supported versions id Flank/flank
1 participant
@adamfilipow92