Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix printing supported versions id #1338

Merged
merged 4 commits into from
Nov 20, 2020

Conversation

adamfilipow92
Copy link
Contributor

@adamfilipow92 adamfilipow92 commented Nov 19, 2020

Fixes #1328

Test Plan

How do we know the code works?

  1. Run Flank with a configured device with not supported API level
  device:
    - model: OnePlus6T
      version: 19

or if you want to check how the message looks when we have more than one supported version


  device:
    - model: Nexus7
      version: 28

  1. Error message should look like:

Incompatible model, 'OnePlus6T', and version, '19'
Supported version ids for 'OnePlus6T': 28


Checklist

  • Fix printing on android
  • Verification and fix iOs
  • Unit tested

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2020

Timestamp: 2020-11-20 14:39:50
Buildscan url for ubuntu-workflow run 374546121

@adamfilipow92 adamfilipow92 marked this pull request as ready for review November 20, 2020 07:29
@bootstraponline bootstraponline force-pushed the 1328-fix-available-versions-id-printing branch from 9760db9 to 9164d45 Compare November 20, 2020 14:34
Co-authored-by: piotradamczyk5 <65554637+piotradamczyk5@users.noreply.github.com>
@piotradamczyk5 piotradamczyk5 self-requested a review November 20, 2020 14:35
@codecov-io
Copy link

Codecov Report

Merging #1338 (52e0d02) into master (6d836d1) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1338      +/-   ##
============================================
- Coverage     79.09%   79.06%   -0.03%     
- Complexity      702      706       +4     
============================================
  Files           244      244              
  Lines          4683     4687       +4     
  Branches        824      824              
============================================
+ Hits           3704     3706       +2     
  Misses          551      551              
- Partials        428      430       +2     

@mergify mergify bot merged commit 0c87150 into master Nov 20, 2020
@mergify mergify bot deleted the 1328-fix-available-versions-id-printing branch November 20, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supported version ids for device printed not correctly
4 participants