Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add basic gameloop IT for Android #1404

Merged
merged 2 commits into from
Dec 16, 2020
Merged

feat: Add basic gameloop IT for Android #1404

merged 2 commits into from
Dec 16, 2020

Conversation

adamfilipow92
Copy link
Contributor

Fixes #1348

Test Plan

How do we know the code works?

  1. Run ./gradlew IntegrationTests
  2. integration.GameloopIT should run
  3. All integration tests should pass

Checklist

  • Integration tests updated

@adamfilipow92 adamfilipow92 self-assigned this Dec 16, 2020
@adamfilipow92 adamfilipow92 changed the title fear: Add basic gameloop IT for Android feat: Add basic gameloop IT for Android Dec 16, 2020
@bootstraponline bootstraponline force-pushed the 1348-android-gameloop-integration-test branch from f520073 to fe27785 Compare December 16, 2020 13:06
@codecov-io
Copy link

codecov-io commented Dec 16, 2020 •
edited
Loading

Codecov Report

Merging #1404 (b4c546e) into master (d676bbd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1404   +/-   ##
=========================================
  Coverage     77.34%   77.34%           
  Complexity      719      719           
=========================================
  Files           250      250           
  Lines          4834     4834           
  Branches        922      922           
=========================================
  Hits           3739     3739           
  Misses          596      596           
  Partials        499      499

@bootstraponline bootstraponline force-pushed the 1348-android-gameloop-integration-test branch from ea37549 to b4c546e Compare December 16, 2020 14:04
@pawelpasterz
Copy link
Contributor

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Dec 16, 2020

Command rebase: success

Branch already up to date

@github-actions
Copy link
Contributor

Timestamp: 2020-12-16 14:29:22
Buildscan url for ubuntu-workflow run 425802619
https://gradle.com/s/eebjuilxrp6g2

@mergify mergify bot merged commit 73c9084 into master Dec 16, 2020
@mergify mergify bot deleted the 1348-android-gameloop-integration-test branch December 16, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelpasterz pawelpasterz pawelpasterz approved these changes

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

Assignees

@Sloox Sloox

@adamfilipow92 adamfilipow92

Labels
Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add gameloop integration test for IOS & Android
5 participants
@adamfilipow92 @codecov-io @pawelpasterz @piotradamczyk5 @Sloox