Fix some memory leak warnings

Fixes #1215
FlansMods · Jun 3, 2020 · a1aae95 · a1aae95
1 parent 27ca7bc
commit a1aae95
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 0 deletions.
diff --git a/src/main/java/com/flansmod/common/network/PacketMechaControl.java b/src/main/java/com/flansmod/common/network/PacketMechaControl.java
@@ -47,6 +47,8 @@ public void decodeInto(ChannelHandlerContext ctx, ByteBuf data)
 		legSwing = data.readFloat();
 		leftStack = ByteBufUtils.readItemStack(data);
 		rightStack = ByteBufUtils.readItemStack(data);
+
+		data.release();
 	}
 
 	@Override

diff --git a/src/main/java/com/flansmod/common/network/PacketPlaneControl.java b/src/main/java/com/flansmod/common/network/PacketPlaneControl.java
@@ -40,6 +40,8 @@ public void decodeInto(ChannelHandlerContext ctx, ByteBuf data)
 		gear = data.readBoolean();
 		doors = data.readBoolean();
 		wings = data.readBoolean();
+
+		data.release();
 	}
 
 	@Override

diff --git a/src/main/java/com/flansmod/common/network/PacketSeatUpdates.java b/src/main/java/com/flansmod/common/network/PacketSeatUpdates.java
@@ -45,6 +45,8 @@ public void decodeInto(ChannelHandlerContext ctx, ByteBuf data)
 		seatId = data.readInt();
 		yaw = data.readFloat();
 		pitch = data.readFloat();
+
+		data.release();
 	}
 
 	@Override

diff --git a/src/main/java/com/flansmod/common/network/PacketTeamInfo.java b/src/main/java/com/flansmod/common/network/PacketTeamInfo.java
@@ -289,6 +289,10 @@ public void decodeInto(ChannelHandlerContext ctx, ByteBuf data)
 			FlansMod.log.throwing(e);
 			teamData = new TeamData[]{new TeamData()};
 		}
+		finally
+		{
+			data.release();
+		}
 	}
 
 	@Override

diff --git a/src/main/java/com/flansmod/common/network/PacketVehicleControl.java b/src/main/java/com/flansmod/common/network/PacketVehicleControl.java
@@ -34,6 +34,8 @@ public void decodeInto(ChannelHandlerContext ctx, ByteBuf data)
 	{
 		super.decodeInto(ctx, data);
 		doors = data.readBoolean();
+
+		data.release();
 	}
 
 	@Override